stocnet / manynet

Many Ways to Make, Manipulate, and Map Myriad Networks
https://stocnet.github.io/manynet/
Other
12 stars 0 forks source link

[macOS] 1 test fails: Error in `read_ucinet_header(file)`: UCINET file with NA levels; please convert separately #20

Closed barracuda156 closed 10 months ago

barracuda156 commented 1 year ago
R version 4.3.1 (2023-06-16) -- "Beagle Scouts"
Copyright (C) 2023 The R Foundation for Statistical Computing
Platform: powerpc-apple-darwin10.8.0 (32-bit)

> library(testthat)
> library(manynet)
Registered S3 method overwritten by 'manynet':
  method          from     
  print.tbl_graph tidygraph
> 
> test_check("manynet")
[ FAIL 1 | WARN 0 | SKIP 7 | PASS 296 ]

══ Skipped tests (7) ═══════════════════════════════════════════════════════════
• On CRAN (7): 'test-map_autographr.R:2:3', 'test-map_autographr.R:17:3',
  'test-map_autographr.R:31:3', 'test-map_autographr.R:49:3',
  'test-map_autographr.R:68:3', 'test-map_autographr.R:96:3',
  'test-map_autographr.R:106:3'

══ Failed tests ════════════════════════════════════════════════════════════════
── Error ('test-make_read.R:99:3'): read_ucinet and write_ucinet works ─────────
Error in `read_ucinet_header(file)`: UCINET file with NA levels; please convert separately
Backtrace:
    ▆
 1. └─manynet::read_ucinet(testthat::test_path("sheets", "ucinettest.##h")) at test-make_read.R:99:2
 2.   └─manynet (local) read_ucinet_header(file)

[ FAIL 1 | WARN 0 | SKIP 7 | PASS 296 ]
Error: Test failures
Execution halted

igraph 1.5.1 migraph 1.0.0

henriquesposito commented 1 year ago

Thank you @barracuda156 for opening this issue!

Unfortunately, I cannot reproduce the test errors in any of the OS we test for. I assume this has to do with the fact that you are running these tests in a powerpc platform (powerpc-apple-darwin10.8.0 32-bit) and we (and CRAN) run all tests in 64-bit OS.

If you are willing to help us and work on this issue, please open a PR and we will gladly review/incorporate your fixes so that the function works on powerpc as well.

Best, Henrique

barracuda156 commented 10 months ago

@jhollway @henriquesposito I apologize, I forgot about the issue. No need to reopen it though; I will add it into my TODO now, and if I can fix it, I will just submit a PR.

Sorry again, and thank you for responding.