search

stocnet / manynet

Many Ways to Make, Manipulate, and Map Myriad Networks
https://stocnet.github.io/manynet/
Other
12 stars 0 forks source link

gglineage not plotting correctly certain nodes #5

Closed delmoralsu closed 1 year ago

delmoralsu commented 1 year ago

Description In the current version of migraph (0.13.2), gglineage appears to have issues rendering the lineage between certain nodes. In the resulting graph, the nodes pile at just one end of the lineage.

To Reproduce The example in the help page of the gglineage function reproduces this issue:

library(migraph)

cites <- dplyr::tibble(qID1 = c("BNLHPB_2016P:BNLHPB_1970A",
                                "PARIS_2015A","INOOTO_2015A", "RUS-USA[UUF]_2015A",
                                "RUS-USA[UUF]_2015A", "RUS-USA[UUF]_2015A", "RUS-USA[UUF]_2015A",
                                "INECHA_2015O", "ST04DC_2014P", "ST04DC_2014P"),
                       qID2 = c("BNLHPB_1977P:BNLHPB_1970A", "UNFCCC_1992A", "INOOTO_2005A",
                                "RUS-USA[MFR]_1988A", "PS07UF_2009A", "UNCLOS_1982A", "UNCLOS_1982A",
                                "ERECHA_1991O", "AI07EM_1998A", "CNEWNH_1979A"))
gglineage(cites)

Created on 2023-04-13 with reprex v2.0.2

Additional context I rolled back the version of migraph to 0.10.1 and gglineage appears to work correctly.

henriquesposito commented 1 year ago

This has been fixed. The issue was related to the false duplication for the years of treaties with a common lineage.