search

stocnet / manynet

Many Ways to Make, Manipulate, and Map Myriad Networks
https://stocnet.github.io/manynet/
Other
12 stars 0 forks source link

Legend issues when mapping edge color for signed networks #80

Open henriquesposito opened 3 months ago

henriquesposito commented 3 months ago

graphr(to_giant(ison_marvel_relationships))

henriquesposito commented 3 months ago

Legends for signed networks were turned off (when "edge_color" is not explicitly declared) since they do not contain any meaningful labels/information for now.

jhollway commented 2 months ago

Is it that the solid red ties are the negative ties or the dashed blue? Perhaps dashed red and solid blue (or green?) would be more consistent/less confusing?

henriquesposito commented 1 week ago

@jhollway I am going through the open issues and I was wondering if this issue was not resolved with the recent changes related to how graphr() works? Thank you.

jhollway commented 1 week ago 
set_manynet_theme("default")
✔ Theme set to default.
graphr(to_giant(ison_marvel_relationships))

This still seems to produce dashed blue ties as negative and solid red as positive, which could be confusing.

image

Should we reverse the 'mnet_highlight' option for signed networks, or use a different option/palette entirely?

henriquesposito commented 1 week ago

Thank you for the feedback @jhollway . I have set levels for positive and negative signs and now the expected colors are assigned accordingly. I wonder, however, if the dashes are necessary? Removing the dashes (e.g. line type) should also help fix issue #99 ...

jhollway commented 1 week ago

Why would that help #99 ? ison_monks %>% to_uniplex("esteem") is a signed network, and should be able to be plotted like above. Dashes are a common way of distinguishing negative ties for greyscale/bw themed plots, at least.