stoermelder / vcvrack-packone

Modules for VCV Rack
GNU General Public License v3.0
173 stars 38 forks source link

Extreme CPU usage on mapping modules in Rack v2 VST #306

Closed Eurikon closed 1 year ago

Eurikon commented 2 years ago

Hi Ben.

thanks for your stopping by at the forum :)

I understand that currently your involvement is on a low pace, but i would like to bring the following to your attention.
Just now i opened a medium sized patch that works pretty fine on 1 thread in the standalone Rack version.

But when i load this same patch in the vst, it immediately brings the vst (therefor the daw as well) to its knees, with crackles.

Upon inspection with the cpu meters on, i see that uMap has an excessive use in the vst topping at 71% When i put the instances (4) of uMap in Bypass, the patch behaves normal.

Screenshot 2021-12-09 at 19 48 38

This is the same patch loaded in the standalone version:

Screenshot 2021-12-09 at 19 51 32

Take care, Latif

Eurikon commented 2 years ago

This is a test with only a vco and umap loaded next to audio core etc. Screenshot 2021-12-09 at 20 06 42

cpu is off the scale 200+ %

:)

stoermelder commented 2 years ago

Reported to VCV as this only indirectly caused by my module

Eurikon commented 2 years ago

Hi Ben, VCV Rack 2.0.6 has been released today, but (after a couple of updates) still no change in the above mentioned issue. Have you heard anything related to this matter, from VCV ?

Edit:

Sorry, i just seen that you have posted about this on the forum just a few days ago: https://community.vcvrack.com/t/stoermelders-idea-und-development-thread/10515/434?u=eurikon

stoermelder commented 2 years ago

As there was no response from VCV support (except for "we got your message") I removed all high resolution options from mapping modules if used inside the VST and added an "Audio rate" option for those modules which hadn't one (µMAP, ReMOVE). The modules behave now differently in the standlone version and VST but it is not possible for me to analyse the VST for the cause.

Secretcinema001 commented 2 years ago

What a bummer the support from Rack is so vague.

As for the CPU overload, is it an option to include even lower Precision modes? Normal Midi has only 128 steps, so maybe that could be a workaround for now, to set precision as low as 128?

Or an option to block Rack from sending out MIDI as an old-fashioned Stoermelder Hack.

The whole VCV community is waiting for your Modules, so I hope we can keep you motivated Ben.

Thanks for the latest build.

Jeroen

Eurikon commented 2 years ago

Hi Ben,

thanks for the follow up. Sorry to hear you haven't gotten any response so far.

I just downloaded and installed the latest build with above commits, and all seems now fine regarding the cpu usage. Hopefully for you it now means you can submit your plugin with this (temporary) work-around to the library.

All the best!

stoermelder commented 2 years ago

I added two additional precision settings for TRANSIT. I hope this helps.

Secretcinema001 commented 2 years ago

That's great Ben.

One hickup unfortunately.

I can select the crazy low (43 Hz) :-) setting in stand-alone and see it work, but in the VST it jumps back to the earlier lowest (689 Hz) setting every time I select the lower settings.

I tried on a different Mac OS, but I only used Bitwig as host. Also, 8Face MK2 glitches the audio when shifting presets in VST mode. Same problem I assume? Need CPU settings there too?

Please do let me know if you want me to keep you posted about this, or you rather wait for a response from Rack dudes.

Cheers.

On Fri, Jan 28, 2022 at 9:30 PM Ben @.***> wrote:

I added two additional precision settings for TRANSIT. I hope this helps.

— Reply to this email directly, view it on GitHub https://github.com/stoermelder/vcvrack-packone/issues/306#issuecomment-1024613516, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUTIQVSXSNHOFZSVT5ZJ6PDUYL4HLANCNFSM5JXGTBQQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: @.***>

-- Secret Cinema http://www.facebook.com/secretcinema.gem :

www.secretcinema.nl http://www.secretcinema.nl www.facebook.com/secretcinema.gem http://www.facebook.com/secretcinema.gem www.instagram.com/secretcinema

*Gem Bookings:Mail: @. @.>Web: www.gembookings.nl http://www.gembookings.nl/secret-cinema/*

stoermelder commented 2 years ago

I'm sorry about the broken precision setting, fixed.

Secretcinema001 commented 2 years ago

No need for a sorry mate, thanks for your fast response.

Happy to be playing with PackOne again!!

On Sat, Jan 29, 2022 at 12:03 PM Ben @.***> wrote:

I'm sorry about the broken precision setting, fixed.

— Reply to this email directly, view it on GitHub https://github.com/stoermelder/vcvrack-packone/issues/306#issuecomment-1024889603, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUTIQVU6AZYTBVZXHICC5ODUYPCQ5ANCNFSM5JXGTBQQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: @.***>

-- Secret Cinema http://www.facebook.com/secretcinema.gem :

www.secretcinema.nl http://www.secretcinema.nl www.facebook.com/secretcinema.gem http://www.facebook.com/secretcinema.gem www.instagram.com/secretcinema

*Gem Bookings:Mail: @. @.>Web: www.gembookings.nl http://www.gembookings.nl/secret-cinema/*

Secretcinema001 commented 2 years ago

Working and no spikes using Transit now.

On Sat, Jan 29, 2022 at 12:59 PM Secret Cinema @.***> wrote:

No need for a sorry mate, thanks for your fast response.

Happy to be playing with PackOne again!!

On Sat, Jan 29, 2022 at 12:03 PM Ben @.***> wrote:

I'm sorry about the broken precision setting, fixed.

— Reply to this email directly, view it on GitHub https://github.com/stoermelder/vcvrack-packone/issues/306#issuecomment-1024889603, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUTIQVU6AZYTBVZXHICC5ODUYPCQ5ANCNFSM5JXGTBQQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: @.***>

-- Secret Cinema http://www.facebook.com/secretcinema.gem :

www.secretcinema.nl http://www.secretcinema.nl www.facebook.com/secretcinema.gem http://www.facebook.com/secretcinema.gem www.instagram.com/secretcinema

*Gem Bookings:Mail: @. @.>Web: www.gembookings.nl http://www.gembookings.nl/secret-cinema/*

-- Secret Cinema http://www.facebook.com/secretcinema.gem :

www.secretcinema.nl http://www.secretcinema.nl www.facebook.com/secretcinema.gem http://www.facebook.com/secretcinema.gem www.instagram.com/secretcinema

*Gem Bookings:Mail: @. @.>Web: www.gembookings.nl http://www.gembookings.nl/secret-cinema/*

Secretcinema001 commented 1 year ago

Hey Ben!

Thanks for the update maestro. I hope you’re ok??

Will check what this means, but I sincerely hope Pack One will be officially added to the official Library of Rack.

I had no issues so far, but it seems midi mapping has some problems as I read in the forum?

Hope you’re making your dreams come true and life is treating you well.

Greets

Jeroen.

On Sun, 11 Sep 2022 at 09:52, Ben @.***> wrote:

Closed #306 https://github.com/stoermelder/vcvrack-packone/issues/306 as completed.

— Reply to this email directly, view it on GitHub https://github.com/stoermelder/vcvrack-packone/issues/306#event-7362028562, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUTIQVSBDUALN43L2JUCFNDV5WFUDANCNFSM5JXGTBQQ . You are receiving this because you commented.Message ID: @.***>

-- Secret Cinema http://www.facebook.com/secretcinema.gem :

www.secretcinema.nl http://www.secretcinema.nl www.facebook.com/secretcinema.gem http://www.facebook.com/secretcinema.gem www.instagram.com/secretcinema

*Gem Bookings:Mail: @. @.>Web: www.gembookings.nl http://www.gembookings.nl/secret-cinema/*

stoermelder commented 1 year ago

Hello Jeroen, yes, I'm going to release a "beta" version to VCV Library soon. Can you give me a link to the forum about the MIDI problems?

Secretcinema001 commented 1 year ago

WOW!! Fantastic news Ben! I will search for you and update you asap. I will also use Pack One now extensively and update you on what I bump into myself if you're keen to know.

many thanks

On Sun, Sep 11, 2022 at 7:50 PM Ben @.***> wrote:

Hello Jeroen, yes, I'm going to release a "beta" version to VCV Library soon. Can you give me a link to the forum about the MIDI problems?

— Reply to this email directly, view it on GitHub https://github.com/stoermelder/vcvrack-packone/issues/306#issuecomment-1243011493, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUTIQVWHVWWX3EWMI4QGL2DV5YLW5ANCNFSM5JXGTBQQ . You are receiving this because you commented.Message ID: @.***>

-- Secret Cinema http://www.facebook.com/secretcinema.gem :

www.secretcinema.nl http://www.secretcinema.nl www.facebook.com/secretcinema.gem http://www.facebook.com/secretcinema.gem www.instagram.com/secretcinema

*Gem Bookings:Mail: @. @.>Web: www.gembookings.nl http://www.gembookings.nl/secret-cinema/*

Secretcinema001 commented 1 year ago

Actually, the one thing I have with Transit is that the state of the saved preset buttons won't reach their saved state on the first click completely. In other words, I need to press the green buttons several times to get to the actual saved state. I am not sure if that has to do with the precision setting? It seems like precision get's less accurate preset recalls.

I map the morph presets mostly to a pad of a midi controller, but then I can press only once when using C4 method. After that the Transit doesn't respond to the same midi key value anymore because it 'thinks' there is no need to respond to that same key press.

Then when I use the mouse on that same saved preset it will fully recover to it's saved state.

I hope this helps

On Sun, Sep 11, 2022 at 7:50 PM Ben @.***> wrote:

Hello Jeroen, yes, I'm going to release a "beta" version to VCV Library soon. Can you give me a link to the forum about the MIDI problems?

— Reply to this email directly, view it on GitHub https://github.com/stoermelder/vcvrack-packone/issues/306#issuecomment-1243011493, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUTIQVWHVWWX3EWMI4QGL2DV5YLW5ANCNFSM5JXGTBQQ . You are receiving this because you commented.Message ID: @.***>

-- Secret Cinema http://www.facebook.com/secretcinema.gem :

www.secretcinema.nl http://www.secretcinema.nl www.facebook.com/secretcinema.gem http://www.facebook.com/secretcinema.gem www.instagram.com/secretcinema

*Gem Bookings:Mail: @. @.>Web: www.gembookings.nl http://www.gembookings.nl/secret-cinema/*