search

stoermelder / vcvrack-packone

Modules for VCV Rack
GNU General Public License v3.0
175 stars 40 forks source link

Rotor consistently crashes on ≈10V mod input #365

Closed Andreya-Autumn closed 12 months ago

Andreya-Autumn commented 1 year ago

Hello! And big thanks for the useful modules. <3

I'm encountering the problem described in the title. I'm on Rack Free 2.1.3, M1 Mac, OS11.6.5. Attaching the crash log, and the patch that triggers it. (The patch needs some plugins, lemme know if you want me to set up a barebones repro patch). Bringing the Bogaudio constant voltage to 10 crashes every time for me. Rotor Crash.txt SaunaDrone.vcv.zip

stoermelder commented 1 year ago

Thanks for reporting, unfortunately I can't reproduce any crash with you patch. I tried it on Windows and I don't have an easy way to test it on a M1 Mac right now. I reviewed the code and can only think of one issue which could occor by numeric precision while rounding numbers. I added some failsafe for this, but it needs confirmation. Please let me know if it still crashes using the latest build (I only provide x64 preview builds for Mac at the moment). https://github.com/stoermelder/vcvrack-packone/releases/tag/Nightly

Andreya-Autumn commented 12 months ago

Thanks! I managed to inadvertently install arm rack over intel rack recently so I gotta get a dual install going to test this. Maybe I'll find the time soon. The good news are I'm also not getting the crash anymore on Arm!

stoermelder commented 12 months ago

I close this issue for now. Feel free to respond if you experience more crashes.