search

stoffi92 / rfc5575bis

0 stars 0 forks source link

IESG Barry Leiba: Section 6 #179

Closed stoffi92 closed 4 years ago

stoffi92 commented 4 years ago

— Section 6 —

By default a Flow Specification NLRI MUST be validated such that it is considered feasible if and only if all of the below is true:

Make it “are true”.

  c) There are no more specific unicast routes

Hyphenate “more-specific” to distinguish it from “there are no more (specific unicast routes)”.

By originator of a BGP route, we mean either the address of the

But nothing else says “originator of a BGP route”. (b) does say “originator of the best-match unicast route”... is that what you mean here? Can you make this match up so it’s clearer?

On thinking more about this text, I think maybe putting quotation marks around “originator” in the quoted sentence is all that’s needed.

Specification information that conveys a more or equally specific destination prefix.

This needs awkward hyphenation ti be correct. I suggest avoiding that by saying, “Specification information that conveys a destination prefix that is more or equally specific.”

Thus, as long as there are no more specific unicast routes, received from a different neighboring AS, which would be affected by that Flow Specification.

As above, hyphenate “more-specific”. And then fix the sentence, as it doesn’t appear to be a complete sentence.

suehares commented 4 years ago

The change should have the following:

old/By default a Flow Specification NLRI MUST be validated such that it is considered feasible if and only if all of the below is true:/ New/By default a Flow Specification NLRI must be validated such that it is considered feasible if and only if all of the conditions below are true:/

The key point for this textual change is that you must indicate a-c are true.

stoffi92 commented 4 years ago

//doc Solved as suggested.

Originator NEW: By originator, we mean either the address of the originator in the ORIGINATOR_ID Attribute , or the source IP address of the BGP peer, if this path attribute is not present.

Corrected the sentence NEW: Thus, as long as there are no "more-specific" unicast routes, received from a different neighboring AS, which would be affected by that Flow Specification, the Flow Specification is validated successfully.