search

stoically / temporary-containers

Firefox Add-on that lets you open automatically managed disposable containers
https://addons.mozilla.org/firefox/addon/temporary-containers/
MIT License
852 stars 60 forks source link

URL bar overflow issues on small width display #364

Open yourduskquibbles opened 4 years ago

yourduskquibbles commented 4 years ago

Actual behavior

$container & #-deletes-history container names will OVERFLOW/overlap the address bar and hide URL and/or display/drawn on-top of other extension icons prohibiting functionality.

Expected behavior

Container name would self-hide and prioritize URL and other extensions over showing the container name.

Steps to reproduce

  1. Set width of browser to something like 900px wide or less (This small width makes the problem immediately apparent to user)
  2. Install a couple other extensions + temporary containers
  3. Notice URL bar will be hidden (user has no idea what domain they are on) and container name will also overlap and block the ability to access extension popup windows from the toolbar.

Please see animated GIF of the problem described tempcontainers_overflow4

Notes

If this behavior of the tab name display priority is a firefox bug, it would still be helpful if temporary containers user would be able to set the x-deletes-history container template name to something less wordy to help with this issue &taking up too much space on screen. Maybe an emoji + number default container name for delete-history containers e.g. ❌-# could be implemented? To me this would convey just as much information to the user and help alleviate this issue if underlying issue is a firefox bug.

stoically commented 4 years ago

That's indeed a Firefox bug, so you might want to consider reporting it on Bugzilla.

However, I can see how the -deletes-history suffix is a bit too much in some cases, be it smaller window sizes or using them often and them just starting to be annoying. I'll look into providing an option to make that shorter, maybe an emoji works, not sure how Firefox handles that.

Until I get around to look into that, a possible workaround might be doing something with CSS, similar to how you can change the container color. I have actually not much experience with that, so you could ask the folks over at r/FirefoxCSS.

yourduskquibbles commented 4 years ago

Thank you for confirming part of the issue is a Firefox bug - I will file an issue on Bugzilla and link back to this thread.

I'll look into providing an option to make that shorter, maybe an emoji works, not sure how Firefox handles that.

That would be great! It could potentially be implemented like the Container Name Prefix field? so user could also have a Deletes-History Container Name Prefix field option that could be user set - I think this would would be a great usability enhancement.

yourduskquibbles commented 4 years ago

An issue has been opened on bugzilla for anyone who wants to track the progress of this bug - https://bugzilla.mozilla.org/show_bug.cgi?id=1610688

stoically commented 4 years ago

It could potentially be implemented like the Container Name Prefix field?

That's a good idea, yeah.

An issue has been opened on bugzilla for anyone who wants to track the progress of this bug - https://bugzilla.mozilla.org/show_bug.cgi?id=1610688

Bugzilla tells me You are not authorized to access bug 1610688 when trying to access that bug.

yourduskquibbles commented 4 years ago

An issue has been opened on bugzilla for anyone who wants to track the progress of this bug - https://bugzilla.mozilla.org/show_bug.cgi?id=1610688

Bugzilla tells me You are not authorized to access bug 1610688 when trying to access that bug.

I opened the bug report as security-sensitive due to potential for phishing attacks with domain being hidden from users - my guess is that tag will probably be removed and bug opened to public soon.

yourduskquibbles commented 4 years ago

Bugzilla Bug 1610688 that I submitted should be viewable now - howeve,r it was marked as dupe of 1545046.

yourduskquibbles commented 4 years ago

I think this may be fixed now in firefox 75+, see: https://bugzilla.mozilla.org/show_bug.cgi?id=1545046 & https://hg.mozilla.org/mozilla-central/rev/77291083babb

It would still be nice to be able to set our own Deletes-History Container Name Prefix naming convention though :)

cornerman commented 2 years ago

It would be really awesome to have a configurable postfix for deletes-history containers. Is there anything, I could help with for that feature?