search

stoically / temporary-containers

Firefox Add-on that lets you open automatically managed disposable containers
https://addons.mozilla.org/firefox/addon/temporary-containers/
MIT License
852 stars 60 forks source link

Considerations for not ignoring Facebook Container #367

Closed kyounger closed 4 years ago

kyounger commented 4 years ago

Not submitting the template, because I think this is more of a discussion.

I noticed that the the Facebook Container is ignored by design. This does cause me one issue, though, as any links clicked on in that container are opened up in the Default container. I have sort of come to expect that any link that tries to open in my browser will never end up opening in the Default Container, and I can be assured of isolation.

Would there be a way to make the two extensions play better together so that links that are clicked on that are not from the facebook domains get opened into a temporary container? I'm very willing to take that up with the Facebook Container repo (maybe even put together a PR) if you can suggest a design that would work.

Thanks for the awesome extension; it changed how I used web browsers!

stoically commented 4 years ago

Didn't realize that websites opened from FBC and similar end up in the default container (with automatic mode and/or isolation enabled, I suppose). Actually I would consider this a bug. Currently it checks whether a tab was opened from FBC, and if that's the case, it completely ignores the request. The reason for that, IIRC, was to prevent tab duplication. Not sure exactly, but I think it should be enough to use the openerTab url check only to remove eventually left-over tabs instead (similar to the redirector tabs logic).

Happy you like the extension!

stoically commented 4 years ago

Was looking into fixing this, but couldn't reproduce it, and also realized that only the initial request gets ignored, which is captured by FC and reopened into the default container - at which point TC reopens, if Automatic Mode is active. So to look into this I'd need steps to reproduce and/or a debug log.

stoically commented 4 years ago

Closing since I can't act on missing STR. If someone can provide STR, please do so.