search

stoically / temporary-containers

Firefox Add-on that lets you open automatically managed disposable containers
https://addons.mozilla.org/firefox/addon/temporary-containers/
MIT License
852 stars 60 forks source link

DDG videos circumvent Left Mouse Isolation #379

Closed crssi closed 4 years ago

crssi commented 4 years ago

FF 73.0.1, Windows 10 TC 1.8

Additional to default settings: General -> Automatic Mode: Check Isolation -> Global -> Mouse Click -> Left Mouse: Choose anything except Never

Open duckduckgo.com. Search for whatever video. Click on any video in the video section.

Expected behavior: link opens only in a new tab/container Actual behavior: link opens in the same tab/container and in a new tab/container

Cheers

stoically commented 4 years ago

Can reproduce. Debug log would be helpful for this one.

crssi commented 4 years ago

I am not sure I understood. You can reproduce or you can't reproduce? If you can reproduce, do you need my debug logs?

stoically commented 4 years ago

I can, but don't have the time to look into it currently, so when I get the time, already having a debug log would help :)

crssi commented 4 years ago

I see. Sure, will try to provide one today.

Cheers and thank you

crssi commented 4 years ago

379.log

stoically commented 4 years ago

While looking into this I found that DDG sends the request to the video again after the first request was correctly canceled by TC. I'm not sure how this could be sanely handled by TC, since it's probably some weird JavaScript magic doing this. Best solution probably would be if TC allowed to define a rule like "if originating from DDG always isolate" - which is something that would be possible with #397.

stoically commented 4 years ago

Closing since the issue itself can't be solved by TC.