search

stoically / temporary-containers

Firefox Add-on that lets you open automatically managed disposable containers
https://addons.mozilla.org/firefox/addon/temporary-containers/
MIT License
852 stars 60 forks source link

Automatic mode reopens tabs in current window, not the original window of the tabs #400

Closed Woundorf closed 4 years ago

Woundorf commented 4 years ago

Steps to reproduce

  1. Have automatic mode enabled
  2. Have a bookmarks folder with several bookmarks (5 or 6 is enough to reproduce for me)
  3. Have 2 or more Firefox windows
  4. Right click on the folder and click "Open all in tabs"
  5. Quickly switch to the other window with Alt+Tab or equivalent shortcut

Expected behavior

Each bookmark is opened in a temporary container in the original window, where the default tabs are created before Temporary Containers can do its work.

Actual behavior

Each bookmark is opened in a temporary container in the current window, which in this case is the other window.

Notes

I guess it's the same issue as #389.

stoically commented 4 years ago

Thanks for the STR, yeah, that makes sense. Currently the windowId isn't defined when reopening tabs, so Firefox is always going to reopen in the currently active window. Should be as easy as adding the windowId from the previous, if known, tab to the tab that get's created.

stoically commented 4 years ago

Fixed in v1.9beta1