search

stoically / temporary-containers

Firefox Add-on that lets you open automatically managed disposable containers
https://addons.mozilla.org/firefox/addon/temporary-containers/
MIT License
852 stars 60 forks source link

Automatic mode on overwrites open in delete history setting (ctrl+click) #413

Closed RaitaroH closed 4 years ago

RaitaroH commented 4 years ago

Actual behaviour

Considering the following settings. Automode overwrites any attempt to open a delete history tab manually unless I use the keyboard shortcut. Alternatively if I make all tabs to be delete history than this will work, but that is not my intent. image

Steps to reproduce

  1. open a delete history tab using shortcut
  2. search test on duckduckgo
  3. now we are in a delete history tab with duckduckgo
  4. ctrl+click on speedtest.net
  5. speedtest opens in normal tmp containers, every time

Expected behaviour

The setting should work as described and open a delete history tab.

Is it possible to have automatic mode on so that sites open in temporary containers, but, have some sort of setting, so that certain domains always open in delete history mode? This should work even if the url is opened from non-temp containar tab, delete history container tab, permanent container tab, history / bookmarks. Pretty much if the link is part of a domain, always open in delete history.

stoically commented 4 years ago

You're right, that seems to be broken indeed. Thanks for letting me know.

Pretty much if the link is part of a domain, always open in delete history.

Interesting idea. I've added that to the list of #397 - that'd be good fit there and allow removing that confusing history preferences screen.

stoically commented 4 years ago

Fixed in v1.9beta1