stoically / temporary-containers

Firefox Add-on that lets you open automatically managed disposable containers
https://addons.mozilla.org/firefox/addon/temporary-containers/
MIT License
852 stars 60 forks source link

Preference to exclude all permanent containers #415

Open Beck-919 opened 4 years ago

Beck-919 commented 4 years ago

Actual behavior

Currently any links clicked in Firefox Multi-Account Containers follow the Temporary Containers' Isolation settings. For example, in my case, inside a 'Multi-Account Container', a link with different domain than the current one opens a new temp container instead of opening in the same user-defined container.

As of now, there is only option to exclude Multi-Account Containers one by one.

Expected behavior

Exclude all user-defined (created manually) Multi-Account Containers from Temporary Containers' Isolation rules. Please provide a single option to exclude all such containers. This is a new problem, have not encountered this before.

stoically commented 4 years ago

This could be covered by #397, with a rule saying e.g.

This is a new problem, have not encountered this before.

Did you by chance enable Isolation > MAC in the preferences? Other than that and excluding permanent containers, TC currently treats all containers equally

Beck-919 commented 4 years ago

You mean install this and then add the rule? Or that you will add it in future?

The following are my current settings, I asking about an extra option in 'Exclude Permanent Containers':

image

Did you by chance enable Isolation > MAC in the preferences?

Is this what you meant by the above?

image

If so, is my current setting correct?

Beck-919 commented 4 years ago

What I basically mean is, whether you can add an 'All Permanent Containers' option in the 'Exclude Permanent Containers' drop-down?

stoically commented 4 years ago

You mean install this and then add the rule? Or that you will add it in future?

It's a planned feature to allow more flexible "If this then that" configuration for isolation. Hence the comparison with the Request Control Add-on, because they're doing that for requests.

Is this what you meant by the above?

Yeah. So that doesn't influence the behavior. What you're experiencing is how TC should behave, treating all containers equal unless excluded.

What I basically mean is, whether you can add an 'All Permanent Containers' option in the 'Exclude Permanent Containers' drop-down?

If I get the chance I'd rather implement #397 than more special case configurations, and it would allow such "exclude all containers" rules. But PRs are welcome to add the special casing, since it should be rather simple to do.