search

stoically / temporary-containers

Firefox Add-on that lets you open automatically managed disposable containers
https://addons.mozilla.org/firefox/addon/temporary-containers/
MIT License
850 stars 58 forks source link

"Links from external programs in temporary containers" should be a separate setting from "Automatic mode" #440

Open roothorick opened 4 years ago

roothorick commented 4 years ago

I want external links opened in temporary containers (which isn't working for me, but I'll make another issue about that), but I use "no container" as effectively another permanent container, which makes full automatic mode counterproductive. I think these functionalities should be separated.

stoically commented 4 years ago

Unfortunately there's AFAIK no way to differentiate between links opened from an external program and just new tabs. So I don't think this is possible to do yet. Would probably need some sort of API enhancement upstream (in the WebExtensions API, request on Bugzilla).

crssi commented 4 years ago

Is there a way that TC would check if tab is opened/"starting to open" in a default container and would (instantly) reopen into a temporary container in that case?

I am using HTTPZ web extension which tries to reopen a non-TLS (that is http) with TLS (https).

See what happens:

  1. FF should be closed
  2. Click on external link, like in an email... for example http://www.swissgear.com
  3. Page is actually opened in a new tab/container becouse HTTPZ redirects it from http to https, where TC AutoMode kicks in.... yeee 😄

If external URL is already https then HTTPZ does not interfere and the tab lands to default container.

Bear in mind that undesired opening in a default container happen here only when FF is initially closed and freshly opened by invoking external URL. If firefox is already opened from before, then external URL always lands in a temp or permanent container as desired.

Maybe you can check if the Firefox is just started and tab in starting to open in a default container it should reopen.

Just brainstorming 😜

stoically commented 4 years ago

@crssi Normally this already works, but it's a regression in Firefox, see https://bugzilla.mozilla.org/show_bug.cgi?id=1653237

crssi commented 4 years ago

I see, thank you.

Is there something you can do as workaround? Otherwise I get a feeling of we have humbly to wait and hope it won't get the WONTFIX status after 2030. 😉

stoically commented 4 years ago

I don't think there's a workaround, bu given that it affects a lot of Add-ons, including Adblockers, and is P2, I'm hopeful that it gets fixed soon.