search

stoically / temporary-containers

Firefox Add-on that lets you open automatically managed disposable containers
https://addons.mozilla.org/firefox/addon/temporary-containers/
MIT License
852 stars 60 forks source link

TC thinks IPv6 literals are not same origin #476

Open dbw9580 opened 3 years ago

dbw9580 commented 3 years ago

Steps to reproduce

  1. Enable "Automatic mode" in TC and choose to isolate when navigating to domains "different from tab domain and subdomains"
  2. Open a page with an IPv6 literal as origin, e.g. http://[fdc0:1::14]/index.html, in a temp container.
  3. Click any link on that page that navigates to some other page of the same origin, e.g. http://[fdc0:1::14]/other.html
  4. See if a new temporary container is created for the navigation.

Actual behavior

A new temporary container is created and switched to on every navigation.

Expected behavior

It's the same origin so no isolation should occur.

Notes

Tested with a fresh Firefox profile and no other extensions are installed.

Debug log that might be related:

Fri, 13 Nov 2020 12:53:41 GMT "[handleRequest] onbeforeRequest requested tab information" {"id":22,"index":5,"windowId":1,"highlighted":true,"active":true,"attention":false,"pinned":false,"status":"loading","hidden":false,"discarded":false,"incognito":false,"width":1536,"height":750,"lastAccessed":1605272021237,"audible":false,"mutedInfo":{"muted":false},"isArticle":false,"isInReaderMode":false,"sharingState":{"camera":false,"microphone":false},"successorTabId":-1,"cookieStoreId":"firefox-container-17","url":"http://[fdc0:1::14]/REDACTED","title":"REDACTED"} undefined background.js:468:25
------------------------------------------ background.js:469:25
Fri, 13 Nov 2020 12:53:41 GMT "[shouldIsolate]" {"id":22,"index":5,"windowId":1,"highlighted":true,"active":true,"attention":false,"pinned":false,"status":"loading","hidden":false,"discarded":false,"incognito":false,"width":1536,"height":750,"lastAccessed":1605272021237,"audible":false,"mutedInfo":{"muted":false},"isArticle":false,"isInReaderMode":false,"sharingState":{"camera":false,"microphone":false},"successorTabId":-1,"cookieStoreId":"firefox-container-17","url":"http://[fdc0:1::14]/REDACTED","title":"REDACTED"} {"requestId":"414","url":"http://[fdc0:1::14]/REDACTED","originUrl":"http://[fdc0:1::14]/REDACTED","method":"POST","type":"main_frame","timeStamp":1605272021235,"tabId":22,"frameId":0,"parentFrameId":-1,"incognito":false,"thirdParty":false,"cookieStoreId":"firefox-container-17","proxyInfo":null,"ip":null,"frameAncestors":[],"urlClassification":{"firstParty":[],"thirdParty":[]},"requestSize":0,"responseSize":0} background.js:468:25
------------------------------------------ background.js:469:25
Fri, 13 Nov 2020 12:53:41 GMT "[shouldIsolateMac] mac isolation disabled" background.js:468:25
------------------------------------------ background.js:469:25
Fri, 13 Nov 2020 12:53:41 GMT "[checkIsolationPreferenceAgainstUrl]" "notsamedomain" "[fdc0:1::14]" "[fdc0:1::14]" background.js:468:25
------------------------------------------ background.js:469:25
Fri, 13 Nov 2020 12:53:41 GMT "[checkIsolationPreferenceAgainstUrl] isolating based on \"notsamedomain\"" background.js:468:25
------------------------------------------ background.js:469:25
Fri, 13 Nov 2020 12:53:41 GMT "[maybeIsolate] decided to isolate" {"id":22,"index":5,"windowId":1,"highlighted":true,"active":true,"attention":false,"pinned":false,"status":"loading","hidden":false,"discarded":false,"incognito":false,"width":1536,"height":750,"lastAccessed":1605272021237,"audible":false,"mutedInfo":{"muted":false},"isArticle":false,"isInReaderMode":false,"sharingState":{"camera":false,"microphone":false},"successorTabId":-1,"cookieStoreId":"firefox-container-17","url":"http://[fdc0:1::14]/REDACTED","title":"REDACTED"} {"requestId":"414","url":"http://[fdc0:1::14]/REDACTED","originUrl":"http://[fdc0:1::14]/REDACTED","method":"POST","type":"main_frame","timeStamp":1605272021235,"tabId":22,"frameId":0,"parentFrameId":-1,"incognito":false,"thirdParty":false,"cookieStoreId":"firefox-container-17","proxyInfo":null,"ip":null,"frameAncestors":[],"urlClassification":{"firstParty":[],"thirdParty":[]},"requestSize":0,"responseSize":0} background.js:468:25
------------------------------------------ background.js:469:25
Fri, 13 Nov 2020 12:53:41 GMT "[maybeIsolate] isolating" {"id":22,"index":5,"windowId":1,"highlighted":true,"active":true,"attention":false,"pinned":false,"status":"loading","hidden":false,"discarded":false,"incognito":false,"width":1536,"height":750,"lastAccessed":1605272021237,"audible":false,"mutedInfo":{"muted":false},"isArticle":false,"isInReaderMode":false,"sharingState":{"camera":false,"microphone":false},"successorTabId":-1,"cookieStoreId":"firefox-container-17","url":"http://[fdc0:1::14]/REDACTED","title":"REDACTED"} {"requestId":"414","url":"http://[fdc0:1::14]/REDACTED","originUrl":"http://[fdc0:1::14]/REDACTED","method":"POST","type":"main_frame","timeStamp":1605272021235,"tabId":22,"frameId":0,"parentFrameId":-1,"incognito":false,"thirdParty":false,"cookieStoreId":"firefox-container-17","proxyInfo":null,"ip":null,"frameAncestors":[],"urlClassification":{"firstParty":[],"thirdParty":[]},"requestSize":0,"responseSize":0} background.js:468:25