stoically / temporary-containers

Firefox Add-on that lets you open automatically managed disposable containers
https://addons.mozilla.org/firefox/addon/temporary-containers/
MIT License
852 stars 60 forks source link

(Firefox) Two tabs open and then one tab closes almost instantly #537

Open Jimmy-Q opened 3 years ago

Jimmy-Q commented 3 years ago

When I open Firefox, two tabs open and then one tab closes almost instantly (leaving me with one tab/window open as expected). I've narrowed down the problem by disabling all other add-ons and the problem only occurs when temporary containers is enabled. When I disable temporary containers the problem doesn't occur. Your help would be much appreciated! Thanks for your good work!!!

Here's a list of my existing add-ons: uBlock Origin Local cdn Clear URLs Cookie Auto Delete PopUpOFF Multi Account Containers Skip Redirect Smart Referrer Facebook container Tampermonkey

Actual behavior

opens 2 tabs at Firefox startup (then closes one almost instantly)

Expected behavior

Open just one tab

Jimmy-Q commented 2 years ago

no response

silverwings15 commented 2 years ago

it seems to appear

@stoically would you be so kind as to provide your input?

silverwings15 commented 2 years ago

adding screen recordings to help better visualize the issue

https://user-images.githubusercontent.com/10742312/138750234-e0a1003c-d246-4141-a816-ee4ec0c61120.mp4

https://user-images.githubusercontent.com/10742312/138750261-b3b630e4-998e-40bd-b028-d2353994d907.mp4

Jimmy-Q commented 2 years ago

Hello, I hope that you're doing well today. The issue only occurs when Stoically/temporary-containers is enabled. When I disable Stoically temporary-containers the issue goes away. My file was too big so I added a link in Imgur. Thank you! I know you must be busy!

https://imgur.com/bX7s9A3

fefo-dev commented 2 years ago

I've also noticed this issue on browser/new tab load. Often just a visual glitch, but if there's some load on your computer the tab might be destroyed and replaced mid typing.

silverwings15 commented 2 years ago

but if there's some load on your computer the tab might be destroyed and replaced mid typing.

yes the visual aspect is whatever, but this is the real problem

Gitoffthelawn commented 2 years ago

I've noticed this too. Firefox 94.0.1 with Temporary Containers v1.9.2. It's been going on for a while, so it doesn't appear to be a recent regression.

stoically commented 2 years ago

Does this happen with "Advanced Automatic Mode" configured to "Don't reopen instantly" or do you have "Blank page" configured as Firefox homepage? If so, then two tabs and one closing is expected behavior, as that's how TC needs to do it. There's no API to convert an existing tab from no container to temporary container.

pixiekat commented 2 years ago

I've had this happen recently too. I'll end up with about 50 random temporary containers in my list that stick around (I have use history deletes instead of temporary by default and have it set to delete immediately after the last tab in it closes).

My homepage is configured as an addon (Tabby Cats, to be exact).

fefo-dev commented 2 years ago

There's no API to convert an existing tab from no container to temporary container.

Looking at the Automatic Mode options it's pretty cut and dry. Hopefully a fix/workaround is available one day; otherwise it's a minor annoyance to deal with this limitation.

stoically commented 2 years ago

@pixiekat

I'll end up with about 50 random temporary containers in my list that stick around (I have use history deletes instead of temporary by default and have it set to delete immediately after the last tab in it closes).

That sounds more like #371

@fefo-dev

Hopefully a fix/workaround is available one day; otherwise it's a minor annoyance to deal with this limitation.

It's a long-standing feature request: https://github.com/mozilla/multi-account-containers/issues/1029 - and given that containers seem to have no priority for firefox at the moment and the task in itself is huge, I'm not hopeful that it'll be available anytime soon.

pixiekat commented 2 years ago

That sounds more like #371

Thanks! I'll subscribe to that one!

Gitoffthelawn commented 2 years ago

Does this happen with "Advanced Automatic Mode" configured to "Don't reopen instantly" or do you have "Blank page" configured as Firefox homepage? If so, then two tabs and one closing is expected behavior, as that's how TC needs to do it. There's no API to convert an existing tab from no container to temporary container.

In General, I have Automatic Mode selected and in Advanced I have Instantly reopen new tabs in [TCs] selected.

For the Firefox home page, I have a moz-extension: URL that loads the page of another extension.

stoically commented 2 years ago

For the Firefox home page, I have a moz-extension: URL that loads the page of another extension.

In that case it's expected behavior. If the flickering is now more visible than in the past, then maybe something in firefox changed in terms of how fast tabs close/open.

Gitoffthelawn commented 2 years ago

For the Firefox home page, I have a moz-extension: URL that loads the page of another extension.

In that case it's expected behavior. If the flickering is now more visible than in the past, then maybe something in firefox changed in terms of how fast tabs close/open.

Thanks for the details. And if I change the home page to a moz-extension: URL to use a bookmark with the same URL or "Use current pages" (with just that moz-extension: URL opened), or other such trickery, would anything change? I'm thinking not, as I'm guessing the issue is that moz-extension: URLs are protected by the Firefox by default.