stoically / temporary-containers

Firefox Add-on that lets you open automatically managed disposable containers
https://addons.mozilla.org/firefox/addon/temporary-containers/
MIT License
846 stars 57 forks source link

Simplify const declaration for regex #612

Open Gitoffthelawn opened 1 year ago

Gitoffthelawn commented 1 year ago

I'm not sure about this... I noticed this strange literal within this const declaration.

If this literal is not needed, please accept the PR. If it's needed, please reject the PR, and if you have time, explain why the matching that literal within the pattern is needed. It looks like perhaps a literal for an exception that is possibly no longer needed.

jonsjava commented 1 year ago

gimsuy is a regex flag, not a literal.

Gitoffthelawn commented 1 year ago

gimsuy is a regex flag, not a literal.

* g - global

* i - case insensitive

* m - multiline

* s - single line

* u - unicode

* y - sticky

Thanks so much. Why aren't the flags located at the end of the regex, as is typical?