stoically / temporary-containers

Firefox Add-on that lets you open automatically managed disposable containers
https://addons.mozilla.org/firefox/addon/temporary-containers/
MIT License
846 stars 57 forks source link

Keep temporary containers after quitting/restart #627

Open msnr opened 1 year ago

msnr commented 1 year ago

It's basically in the the title and I could not find something like this in my settings. If I quit Firefox properly the next time I open it up and with it my gazillion tabs all my temporary containers are gone so the tabs open up without any. Is there away to "fix" this?

Naheulf commented 12 months ago

It's a Firefox setting unrelated to temporary-containers. In about:preferences#general under General>Startup select Open previous windows and tabs.

twelho commented 10 months ago

The tabs are restored, but the temporary containers are (sometimes) not, this has been an issue with the extension since its inception. I am not aware of any workaround.

twelho commented 10 months ago

I think I might have just figured this out: if you have a tab in a temporary container, and you close the browser when that tab is not selected, on the next launch the tab will only get loaded once you navigate to it. In this unloaded state, the tab does not count as being part of the temporary container, so the TC extension goes ahead and deletes the "empty" container based on your cleanup settings (e.g. timeout). Next time you launch the browser, the tab ends up without a container.

Naheulf commented 10 months ago

I'm unable to reproduce on a new Firefox install with only TC. Maybe it's setting dependant or it's a compatibility issue with another addon? Are you able to reproduce it in a new Firefox profile? (See https://support.mozilla.org/en-US/kb/profile-manager-create-remove-switch-firefox-profiles to view how to create a new profile)

twelho commented 10 months ago

I'm using TC together with the official Multi-Account Containers extension as well as Containerise, both should be supported. In order to debug this further, I enabled container deletion messages, which pointed out one problem: all my containers were kept until I closed the browser and opened only a private window. Even though TC is supposedly not running in private windows, the cleanup process seemingly still is, as I got a notification of all of my temporary containers being deleted. Sure enough, when re-opening the main (non-private) profile, all the containers were gone. I'm pretty sure this is the issue (at least for me) since I only see it "intermittently", in regular use my containers are persisted across browser restarts. This has actually been reported here before (https://github.com/stoically/temporary-containers/issues/619), any idea how to address this?

twelho commented 10 months ago

In this unloaded state, the tab does not count as being part of the temporary container, so the TC extension goes ahead and deletes the "empty" container based on your cleanup settings (e.g. timeout).

I can also debunk this, unloaded tabs still are still present when TC is iterating tabs and also retain their container information, so that is not a condition for containers to get mistakenly deleted.

msnr commented 9 months ago

Hey, thanks for having a look. I might have found the issue on - as so often - the user side. Sometimes I just open an new private window bc I just want to google smth and without opening my gazillion tabs. This seems like to be the issue bc when no tabs are opened TC sees the container as not in use anymore and deletes them. So if I open up FF normally all TC containers are gone.

Edit: And I I jsut saw @twelho already mentioned this 😄