Page action button (in address bar) does not display if tab is in no container at all - Githubissues

stoically / temporary-containers

Firefox Add-on that lets you open automatically managed disposable containers

https://addons.mozilla.org/firefox/addon/temporary-containers/

MIT License

846 stars 57 forks source link

Page action button (in address bar) does not display if tab is in no container at all #639

Open nike4613 opened 1 month ago

nike4613 commented 1 month ago

Temporary Containers Version: 1.9.2
Firefox Version: 115.13.0 (Floorp 11.15.0)

Actual behavior

No page action button when tab does not have container

Expected behavior

The page action button to be present even when a tab is not in a container

Steps to reproduce

Open a tab outside any containers (you can use the Sideberry extension, for instance, to do so)
Observe lack of button, even with option enabled

Notes

It seems to be this code that causes the problem:

https://github.com/stoically/temporary-containers/blob/cbb39f7abbdf3c767bd1fbdc109394a0db169b05/src/background/pageaction.ts#L43-L45

I see in the debug console for the background page this error: