stoicflame / enunciate

Build-time enhancement tool for Java-based Web services projects
http://enunciate.webcohesion.com/
Other
480 stars 201 forks source link

Add compatibility with different reporting apis #1190

Closed fhm84 closed 11 months ago

fhm84 commented 11 months ago

As reference to https://github.com/stoicflame/enunciate/pull/1165

Hi @stoicflame we just tested enunciate 2.17.1 on maven 3.9.5 (java 21) using maven-site-plugin:3.12.1 ... unfortunatelly, it didn't work, because of missing method exception. But we found a way to get it run (and from my point of view, this should also be backwards-compatible). Even if in the meanwhile org.codehaus.doxia.sink.Sink extends org.apache.maven.doxia.sin.Sink, I think we just could/should provide 2 generate-methods: one for each type. And by removing @Overwrite annotation, from my point of view, we might also be "safe" for the future ;) - especially, because currently this sink is not used within this method.

stoicflame commented 11 months ago

https://github.com/stoicflame/enunciate/commit/a6f7fe9b7bc55fc7c8cb5e4dfa9d5a0282d8511d