search

stoiveyp / Slack.NetStandard

.NET Core package that helps with Slack interactions
MIT License
41 stars 16 forks source link

OAuthV2Builder.BuildUri() doesn't work because ClientId is always null #35

Closed AbsShek closed 3 years ago

AbsShek commented 3 years ago

ClientId is always null because it is not saved in the constructor.

https://github.com/stoiveyp/Slack.NetStandard/blob/20d78e24c9cf38ebc0beabaa721966434069f6f4/Slack.NetStandard/Auth/OAuthV2Builder.cs#L33 https://github.com/stoiveyp/Slack.NetStandard/blob/20d78e24c9cf38ebc0beabaa721966434069f6f4/Slack.NetStandard/Auth/OAuthV2Builder.cs#L15-L21

stoiveyp commented 3 years ago

Thanks for raising these issues @AbsShek, they're now fixed and being deployed as part of v2.8.3 and 2.9.0-beta4 👍

AbsShek commented 3 years ago

⭐ Amazing! Thanks!