search

stoiveyp / Slack.NetStandard

.NET Core package that helps with Slack interactions
MIT License
41 stars 16 forks source link

Update Epoch to be based off DateTime.UtcNow #47

Closed kzhen closed 3 years ago

kzhen commented 3 years ago

I was trying out the RequestVerifier for my slack slash command handler and noticed that it would never come back as verified when using the Verify() method but if I compared the results of RequestVerifier.GenerateSignature() with the header value then they matched. It seems the issue is that since the UK is now in BST time using DateTime.Now instead of DateTime.UtcNow causes .Verify() to always return false since the timestamp isn't within the allowed time period.

I have also fixed a very minor typo on the README file.

stoiveyp commented 3 years ago

Thanks for spotting this - it's been released in v2.15.2