stoiveyp / Slack.NetStandard

.NET Core package that helps with Slack interactions
MIT License
41 stars 16 forks source link

V4 - Update to use lists for all request calls/objects #73

Closed stoiveyp closed 2 years ago

stoiveyp commented 2 years ago

V4 ensures that wherever a collection is required for creating/requesting information from Slack - it uses a List property rather than the previous Array usage.

Lists are always new'ed up as part of construction, and a ShouldSerialize method has been added for every property to ensure that they're not included in the request if they're empty (could have used a JSON.Net contract but that meant breaking all existing implementations where serialization was being used outside of the client such as sending via a response URL)

New Roslyn Analyzers added to the project to ensure future changes don't revert these rules.