search

stojanovic / scottyjs

Deploy static websites and single page apps to AWS S3 and CloudFront with a single command
http://medium.com/@slobodan/single-command-deployment-for-single-page-apps-29941d62ef97
MIT License
707 stars 37 forks source link

[Bugfix] Fix aws profile configuration for S3 clients. #20

Closed chasdevs closed 6 years ago

chasdevs commented 7 years ago

Before, the S3 clients in each lib module were instantiating upon initial require, so mutating the global AWS configuration by setting a different profile did not propagate and all S3 clients used the "default" profile. This PR expands on the dependency injection pattern which was established in the code for "s3lib" and uses it when applicable.

stojanovic commented 6 years ago

Sorry for taking too long to accept this one. And thanks! It will be on NPM soon.