Use Skin Shortcuts addon for custom home items

[jingai]

http://forum.xbmc.org/showthread.php?tid=178294

MacGyverr's had a stab at this: https://github.com/MacGyverr/Metropolis/tree/helix-custommenu-rewrite

[jingai]

A lot of this is in one massive commit:

https://github.com/MacGyverr/Metropolis/commit/8d288d76b80166a02b4f42be2d20cce236598ce7#diff-6ed3b9d8d2723487e6162eb621a63dc4R134

The changes pertinent to skin.shortcuts seem to be in: addon.xml Home.xml Includes.xml SkinSettings.xml Includes_Home?.xml Includes_HomeDeck.xml script-skinshortcuts*

[MacGyverr]

Done.

https://github.com/MacGyverr/Metropolis/commit/4b4dd260d33b6876129a2bc8425e7317da88df02

Try it without the Home.xml launched rebuild code, I think that the one in SkinSettings is enough.

[jingai]

Noting to update the features at http://kodi.wiki/view/Add-on:Metropolis when this is complete.

[MacGyverr]

Just finished the playlist widget and further HomeDeck refinements. https://github.com/MacGyverr/Metropolis/commit/421abb9105dbcb5701975c6efc23e2e72326c503 Example screenshots at the bottom in the comments.

[jingai]

Thanks MacGyver.

This particular issue is high on my priority list, but we have family coming into town for a week so it'll be a little bit before I can look over all you've done.

[MacGyverr]

I was going to include addons widgets like the other skins, but it seems kind of redundant as any addons can be added as a submenu to any menu (or as its own menu shortcut). I'm not sure I can see why anyone would want to have a widget that displays a list of ALL the addons? If I'm being short-sighted let me know and I'll code it up.
At this point the HomeDeck include file is almost a complete rewrite. Also, the in the comparison chart for Helix you have "Custom Home Items" showing no, and while the official version doesn't have complete customization options, it is by no means a No.
Anyway, have fun with the family. :)

[jingai]

You and I both know people (often adamantly) want some really strange things.. lol.. but hold off on that for now. I'll be giving this all a really thorough look when I get the chance. The core of Metropolis is close to where I want it to be now, so this will be addressed soon.

But, as for the feature on the wiki, I listed that as a No for now because I think what people really expect when they see that box ticked is the kind of customization addressed by this issue. Really.. it was debatable either way so I just held off on the "yes" until it's completely done (a la the mods you've made here).

[jingai]

Just noting this here:

http://forum.kodi.tv/showthread.php?tid=213669&pid=1890929#pid1890929

[jingai]

Getting closer on this.. few things remain:

• everything in shortcuts/overrides.xml and 720p/script-skinshortcuts.xml needs to be localized
• media overlay for music overlaps the widgets
• i want a custom widget for addons to retain the old icon-based list we had before
• skin for script.skinshortcuts is behaving.. oddly.. need to see if I missed one of your commits or something

[MacGyverr]

"media overlay for music overlaps the widgets" My version solves this for the home menus, I just need to add the settings menus to the list of conditionals of where not to display. Cut and paste as needed. :)

[jingai]

Which version are you referring to? The menurefactor branch was showing it overlapping because the condition in Includes_MediaOverlay.xml hadn't been updated.

[MacGyverr]

I stopped updating that branch because I was afraid it was getting too far off of the official for you to be able to merge properly. Do you have an official Menu-refactor branch that I can fork off of? Do you have an offline one that is now equal to it? I was updating my personal version with little fixes until you had an official branch with the menu-refactor, that way I could have an idea for code fixes that might come up with the switch to Jarvis.

[jingai]

Aye, that's why I've been watching your commits on your personal version :)

I will be pushing it all into master soon. I do have a branch at jingai/skin.metropolis currently, but I'm force-pushing it currently, so I don't recommend branching from there.. in fact, I'll go ahead and merge this in so you can help out if you want to. I'll make separate Issues for each thing that still needs to be completed.

It's almost done really. Last remaining issues/questions:

• The strings in shortcuts/overrides.xml need to be localized. Kodi team won't accept the PR without this.
• Media Overlay overlaps widgets. FYI, I get around having to use any special conditions for the settings dialog text (PlotBox) by dynamically adjusting the PlotBox size if the overlay is present. The only conditions remaining are 1) mediaflags present (this is easy), and 2) widget is currently visible.
• Playlist widget fanart is squished into poster width. Should match the other widgets, where they extend the width if it's fanart and not a poster.
• Playlist widget needs to show artwork always in Home1 view. Widgets never disappear in Home1.
• Want to support multi-image for backgrounds. Likewise, I want to allow the user to change the icon (for Home2).
• I'd like to retain the old Addons "widget", displaying 5 icons horizontally. This can wait for a future release though.

[jingai]

It's all sitting at https://github.com/stoli/Metropolis/tree/refactor now. I'm going to make separate issues for the things that need to be done before I can release.

I won't force-push to that branch, so you're safe to branch from there if you want.

[jingai]

All Issues created. Closing this now.