stoli / Metropolis

Continuation of Metropolis skin for XBMC
Other
23 stars 21 forks source link

Fanart Fullscreen view for videos #301

Closed marcelscode closed 9 years ago

marcelscode commented 9 years ago

Hi,

I created a new view for videos (movies, tvshows) that uses the fanart fullscreen (minus the info area on the bottom). In the bottom area not the plot is shown but the title (using clearart, clearlogo or just text - whatever is available) and further information. What is missing is localization (I left two TODOs in the code) for the view's name. I am not sure how to do this. This might be an easy thing for you if you choose to include this in Metropolis.

If you think this is a nice addition to your skin, please merge. If you do not like it, this is fine as well. Feel free to reject this.

Thanks for your work!

Marcel

jingai commented 9 years ago

I appreciate the effort, but this view violates one of my fundamental design decisions: the bottom area is sacred. It should be the same for all views.

It also has some issues beyond that, as shown here:

screenshot000

Additionally, did you have some particular use-case in mind for this view? For any reasonably-sized library, it just doesn't present enough on the screen at a time to be really useful. I couldn't imagine scrolling through the 800 movies I have available in this manor.

Was the view intended for some streaming service addon or something?

marcelscode commented 9 years ago

Thanks for the feedback, I appreciate it. Looks like I failed to thoroughly test this. Your design principle about the bottom space would certainly require a slightly different approach to implement what I tried to do.

I previously used Bello as skin, which comes with a similar view. I use it for TV shows for the looks, the presentation of the fanart in my view is very eye-catching as it dominates the whole screen. Your skin has a similar fanart view, but the viewed fanart it rather small and includes the covers of the previous and next item in the list, which I feel is not necessary. I totally agree that such a view does not work for movie collections, even if you have only a few dozen movies (I prefer list views there) - but this is also true for some of the already existing cover-flow-like views (e.g., fanart).

Question is if you would be generally interested in such a view. Then, I would put some more work into this, in particular keeping clear of the bottom space (and additional principles you want to be followed). This was my first try in doing some skinning work for kodi, so this is already an interesting experience for me.

jingai commented 9 years ago

I personally feel the existing Fanart views satisfy this.

Considering you wanted the ClearLogo/ClearArt as well, maybe you could tell me why the Logo view doesn't do the trick for you? Because of the diffuse overlay on the fanart? You could easily do something like this:

screenshot000

edit: better example -- it's the existing Logo view but with the diffuse overlay removed.

jingai commented 9 years ago

Or something like this, if you really don't want to see the next and previous items:

screenshot000

I'm not likely to put something like this in the official version, but I can tell you how to do it for yourself easily enough. It was just the removal of a couple lines.

jingai commented 9 years ago

I went ahead and made the option to show only one item at a time in the Logo view:

screenshot002

and to brighten up the background fanart:

screenshot004

resulting in the Logo view looking like this:

screenshot003

marcelscode commented 9 years ago

Cool, thanks for the change and your effort.