search

stoli / Metropolis

Continuation of Metropolis skin for XBMC
Other
23 stars 21 forks source link

Button selection highlight line goes behind profile image in Edit Profile dialog #316

Closed jingai closed 8 years ago

jingai commented 9 years ago

screenshot013

MacGyverr commented 9 years ago

https://github.com/MacGyverr/Metropolis/commit/12210365d5593fa6e2b19317b73e32ecdd74fe85

screenshot005

jingai commented 8 years ago

To be honest, I think it looks fine the way it was, and matches the rest of the left side buttons in the skin better. What do you think?

MacGyverr commented 8 years ago

I think it looked fine before.

What about moving the icon and description down below in the info bar? b6a9379e-3edb-11e5-81f4-fab95a9c35b6

Or moving the ok buttons lower?

b6a9379e-3edb-11e5-81f4-fab95a9c35b6-2

jingai commented 8 years ago

I think it looks weird personally any other way than it was lol. It's not a huge deal though.

MacGyverr commented 8 years ago

I like the old way, going behind the picture seems kind of artsy. What above or below? b6a9379e-3edb-11e5-81f4-fab95a9c35b6-3

jingai commented 8 years ago

Yeah, honestly I don't think it looks 'wrong' the way it was.. it looks intentional to me, unless of course one is aware of this discussion ;)

Going to leave it as it was.