stolk / chiaharvestgraph

Graphs the activity of a chia harvester in a linux terminal.
MIT License
202 stars 27 forks source link

Color for current pixel #16

Closed HitLuca closed 3 years ago

HitLuca commented 3 years ago

There are some cases where it's not clear where in the graph the cursor is, so having a specific color to indicate that would be nice. You can see an example in the image below: is the current pixel the red one? Or did the harvester fail to harvest and we are in one of the next pixels?

Screenshot from 2021-05-16 11-02-46

Even a black or white pixel border would be enough I believe

stolk commented 3 years ago

Please update to the latest version.

$ git pull

It no longer shows future time as red.

On Sun, May 16, 2021 at 2:04 AM Luca Simonetto @.***> wrote:

There are some cases where it's not clear where in the graph the cursor is, so having a specific color to indicate that would be nice. You can see an example in the image below: is the current pixel the red one? Or did the harvester fail to harvest and we are in one of the next pixels?

[image: Screenshot from 2021-05-16 11-02-46] https://user-images.githubusercontent.com/7645621/118391769-54ac4f80-b636-11eb-85c9-d03a3127cb44.png

Even a black or white pixel border would be enough I believe

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/stolk/chiaharvestgraph/issues/16, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADPE4EMPONNGIETUEIUYUDTN6DDTANCNFSM446XISOQ .

-- Owner/Director of Game Studio Abraham Stolk Inc. Vancouver BC, Canada @.***

HitLuca commented 3 years ago

I'm already up to date with master but looks like the future time is still shown in red. The screenshot reflects what I currently see If it can help I'm on Ubuntu 20.04, running on the default terminal

stolk commented 3 years ago

Is the past, beyond oldest log in grey or red? Resize term really wide to see past.

HitLuca commented 3 years ago

Right now it's red, but I remember it being grey so it probably changed when pulling

stolk commented 3 years ago

That makes no sense. You somehow reverted to old version.

Just delete the entire chiaharvestgraph directory, and git clone it again.

On Sun, May 16, 2021 at 6:54 AM Luca Simonetto @.***> wrote:

Right now it's red, but I remember it being grey so it has probably changed when pulling

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/stolk/chiaharvestgraph/issues/16#issuecomment-841820898, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADPE4EYFCSMKARZE4GE5CDTN7FDBANCNFSM446XISOQ .

-- Owner/Director of Game Studio Abraham Stolk Inc. Vancouver BC, Canada @.***

stolk commented 3 years ago

Line 344 should look like this...

        red = grn = blu = 0x36;
HitLuca commented 3 years ago

Yep, I have the same

ATmarked commented 3 years ago

since this is compiled, it could also happen if someone forgets to rebuild after the pull, or ran an old binary.

Maybe the screen needs to show a version number to reduce confusion. Or someone in the updating notice lines.

HitLuca commented 3 years ago

Aaah dammit yup, 8 years of python led me to forget recompiling! Gonna try in a minute and let you know

HitLuca commented 3 years ago

I can confirm that recompiling brought the code up to date and correctly shows the new changes Screenshot from 2021-05-17 16-46-58