search

stolostron / ansible-collection.core

OCM/ACM Ansible Collection
Apache License 2.0
19 stars 13 forks source link

add option to configure name or generate_name for managed-serviceaccount #105

Closed TheRealHaoLiu closed 2 years ago

TheRealHaoLiu commented 2 years ago

closes https://github.com/stolostron/ocmplus.cm/issues/87

tphee commented 2 years ago

@TheRealHaoLiu Could you update this playbook https://github.com/stolostron/ocmplus.cm/blob/main/tests/integration/targets/multicluster_management/tasks/multicluster-management-playbook.yml#L29-L36

tphee commented 2 years ago

@TheRealHaoLiu At the end of the playbook is missing the task to delete managed_serviceaccount:

    ocmplus.cm.managed_serviceaccount:
      state: absent
TheRealHaoLiu commented 2 years ago

updated PR per @tphee 's comment

hanqiuzh commented 2 years ago

/lgtm

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hanqiuzh, TheRealHaoLiu, tphee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/stolostron/ocmplus.cm/blob/main/OWNERS)~~ [TheRealHaoLiu,hanqiuzh] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment