add mch version check - Githubissues

stolostron / ansible-collection.core

OCM/ACM Ansible Collection

Apache License 2.0

19 stars 13 forks source link

add mch version check #119

Open hanqiuzh opened 2 years ago

hanqiuzh commented 2 years ago

Signed-off-by: Hanqiu Zhang hanzhang@redhat.com

Tests:

[x] block all plugins in acm 2.4
[x] allow managed-serviceaccount and managed-serviceaccount-rbac to work in mce
[x] block non managed-serviceaccount plugins in mce
[x] allow all plugins in acm 2.5
[x] warn if no permission to check versions

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hanqiuzh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/stolostron/ocmplus.cm/blob/main/OWNERS)~~ [hanqiuzh] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

hanqiuzh commented 2 years ago

/hold will add some unit tests for this

hanqiuzh commented 2 years ago

/unhold

hanqiuzh commented 2 years ago

/hold waiting to see if we will have installer to provide an API which doesn't need permission

openshift-ci[bot] commented 2 years ago

@hanqiuzh: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.