search

stolostron / ansible-collection.core

OCM/ACM Ansible Collection
Apache License 2.0
19 stars 13 forks source link

fix bug that cause clusterrolebinding roleref to not be properly renamed #135

Closed TheRealHaoLiu closed 2 years ago

TheRealHaoLiu commented 2 years ago

this PR fixes a bug that cause roleRef for the RoleBindgs not to be properly renamed if its referencing a created role causing permission to not be properly assigned

nathanweatherly commented 2 years ago

/lgtm /approve

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nathanweatherly, TheRealHaoLiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/stolostron/ocmplus.cm/blob/main/OWNERS)~~ [TheRealHaoLiu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment