ACM & MCE Product Version Checking for Plugins & Modules

stolostron / ansible-collection.core

OCM/ACM Ansible Collection

Apache License 2.0

19 stars 12 forks source link

ACM & MCE Product Version Checking for Plugins & Modules #91

Open nathanweatherly opened 2 years ago

nathanweatherly commented 2 years ago

Our internal code needs to run checks to confirm the supported versions of ACM/MCE are running (else throw concise errors)

nathanweatherly commented 2 years ago

Acceptance Criteria:

Must have MCE 2.0 and/or ACM 2.5 as base (nothing before)
Check MCE and ACM CR for version (if user has permissions)
If user doesn't have permissions to view MCE or ACM version, what do we do?
- Ignore and throw warning?
How do we check if MCE or ACM are installed at all?
Do we need to do the check for every plugins and modules?
Define in one utils location and ref at the beginning of every plugins and modules?
DESIGN NEEDED

Complexities:

Design needed

hanqiuzh commented 2 years ago

Didn't see a version field in MCE CRs. Guess we can only check for MCH versions.

nathanweatherly commented 2 years ago

That should be fine for 2.5 since cluster proxy is in ACM. I will ask installer if MCE has/will have a version field at some point.

nathanweatherly commented 2 years ago

From Install team

Nathan:
Hey! How do you guys check the version of MCE you’re running? I know the MCH has a currentVersion or whathaveyou-- is there some backplane equivalent?

Jakob Gray-
No, you could parse it from the CSV version installed.

hanqiuzh commented 2 years ago

PR: https://github.com/stolostron/ocmplus.cm/pull/119

Currently, it only shows warning if user is using an RBAC account (without proper permission to check version). It exit when found the current version < target version, but not sure if we should simply send a warning or we should exit.

Better discuss at next scrum 😂