search

stolostron / deploy

Deploy Development Builds of Open Cluster Management (OCM) on RedHat Openshift Container Platform
Apache License 2.0
158 stars 153 forks source link

Update uninstall.sh #164

Open Kyl-Bempah opened 4 years ago

Kyl-Bempah commented 4 years ago

PR made for https://github.com/open-cluster-management/backlog/issues/6177, need to finish editing script.

TheRealHaoLiu commented 4 years ago

as part of the uninstall during canary i dont think we care about the rest of the manual cleanup

all we care is if mch is deleted successfully if mch delete hangs (with some timeout set) than we fail the testcase and move on

TheRealHaoLiu commented 4 years ago

any forward movement with this PR?

Kyl-Bempah commented 4 years ago

Uninstall script has been added, watch of mch status and supplemental code paths need to be added to canary & canary-scripts.

openshift-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Kyl-Bempah To complete the pull request process, please assign after the PR has been reviewed. You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/open-cluster-management/deploy/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Kyl-Bempah To complete the pull request process, please assign after the PR has been reviewed. You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/open-cluster-management/deploy/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 3 years ago

@Kyl-Bempah: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.