search

stolostron / deploy

Deploy Development Builds of Open Cluster Management (OCM) on RedHat Openshift Container Platform
Apache License 2.0
158 stars 153 forks source link

Add Backplane Installation #200

Closed zkayyali812 closed 3 years ago

zkayyali812 commented 3 years ago

Signed-off-by: Zachary Kayyali zkayyali@redhat.com

Description of the change: Allows for standard installation of backplane-operator

Motivation for the change: Allows for standard installation of backplane-operator

schmidtd commented 3 years ago

This seems to be localized to backplane operations, as I'm not a deploy repo expert. /shrug /lgtm

zkayyali812 commented 3 years ago

@tpouyer I think it would be better left separate, at least for now. ACM and Backplane cannot be installed on the same cluster, so having a separate script seems better in this case, especially as we grow to further develop it.

tpouyer commented 3 years ago

@zkayyali812 there already exist "flags" in the start.sh script for using "downstream" vs "upstream" builds of ACM and "composite" bundle vs "non-composite" bundles... both of these flags change the specific kustomizations that are used to deploy ACM.

I understand the desire to keep this separate especially right now as backplane is very "early" in development. If you feel strongly about having a separate start.sh script for backplane can I suggest we put that script in a sub-folder of the root so as to not confuse anyone right now. Additionally in that sub-folder can you add a new README.md file to explain what backplane is and how to install it and possibly what is included?

zkayyali812 commented 3 years ago

@tpouyer Absolutely. I will update to move the script to the backplane directory and add the associated doc. I'd like to keep it separate for now, but we may revise this in the future.

tpouyer commented 3 years ago

@tpouyer Absolutely. I will update to move the script to the backplane directory and add the associated doc. I'd like to keep it separate for now, but we may revise this in the future.

@zkayyali812 I'll approve the PR once you make those changes

openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Kyl-Bempah, schmidtd, zkayyali812

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management/deploy/blob/master/OWNERS)~~ [Kyl-Bempah] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment