search

stolostron / deploy

Deploy Development Builds of Open Cluster Management (OCM) on RedHat Openshift Container Platform
Apache License 2.0
158 stars 153 forks source link

Allow start.sh to dynamically pick its channel #253

Closed jnpacker closed 2 years ago

jnpacker commented 2 years ago

Signed-off-by: Joshua Packer jpacker@redhat.com

Description of the change: multiclusterengine/start.sh did not work for 2.1.0-backplane snapshots. Did not set the correct subscription channel.

Motivation for the change:

I required the deployment of the 2.1.0-backplane snapshot.

jnpacker commented 2 years ago

/cc @zkayyali812 @cdoan1

Someone probably wants to take a look at the regular start.sh and upgrade.sh

jnpacker commented 2 years ago

@gurnben

zkayyali812 commented 2 years ago

/lgtm

gurnben commented 2 years ago

LGTM!

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: jnpacker, zkayyali812

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/stolostron/deploy/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment