search

stolostron / deploy

Deploy Development Builds of Open Cluster Management (OCM) on RedHat Openshift Container Platform
Apache License 2.0
158 stars 153 forks source link

Fixed annotation mishap in example-multiclusterhub-cr #256

Closed MacdonEm closed 2 years ago

MacdonEm commented 2 years ago

Description of the change: Updated example-multiclusterhub-cr to have catalog source annotation hardcoded but other annotations removed.

Motivation for the change: In the event of a disconnected install or any similar circumstance, the catalogsource annotation is required. To overwrite the default behavior, the catalogsource annotation has been added back in. After discussion over the rest of the annotation overwrite, it was concluded the other aspects (like name and channel) were still unneeded so they were not added back in. (This was tested to verify successful install in a simulated disconnected environment and found to be true).

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Kyl-Bempah, MacdonEm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/stolostron/deploy/blob/master/OWNERS)~~ [Kyl-Bempah] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment