search

stolostron / deploy

Deploy Development Builds of Open Cluster Management (OCM) on RedHat Openshift Container Platform
Apache License 2.0
158 stars 153 forks source link

Allow deploy on OCP 4.11 #258

Closed Jaanki closed 2 years ago

Jaanki commented 2 years ago

The regex expects OCP from 4.3 to 4.10. start.sh script fails with OCP 4.11. Change the regex to also match 4.11. This will allow deploy to be run on OCP 4.11

Signed-off-by: Janki Chhatbar jchhatba@redhat.com

Description of the change:

Motivation for the change:

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Jaanki To complete the pull request process, please assign kyl-bempah after the PR has been reviewed. You can assign the PR to them by writing /assign @kyl-bempah in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/stolostron/deploy/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Jaanki commented 2 years ago

/assign @Jaanki

Jaanki commented 2 years ago

/assign @kyl-bempah

Jaanki commented 2 years ago

@Kyl-Bempah May be it is early for this change , given that OCP 4.11 is not GA yet? I was trying it out for OCP 4.11 and noticed the missing regex version match and hence the PR.

Kyl-Bempah commented 2 years ago

Yeah we may wait on this for 4.11 to GA, but I will look at expanded the expected value so we don't have to explicitly enumerate 10+ versions

Kyl-Bempah commented 2 years ago

Thank you for finding this, to avoid having to do this for future OCP releases, we're removing this check entirely in https://github.com/stolostron/deploy/pull/260