stolostron / deploy

Deploy Development Builds of Open Cluster Management (OCM) on RedHat Openshift Container Platform
Apache License 2.0
157 stars 152 forks source link

Add helper script to change the deployed MCO image #272

Closed douglascamata closed 5 months ago

douglascamata commented 11 months ago

Description of the change:

Added a small shell script to automate changing the MCO image deployed in a cluster through the CSV resource.

Motivation for the change:

Manual work that has many steps which can have mistakes or be forgotten.

openshift-ci[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: douglascamata, saswatamcode Once this PR has been reviewed and has the lgtm label, please assign gurnben for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/stolostron/deploy/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
coleenquadros commented 8 months ago

@douglascamata this might not work from ACM 2.9 onwards. We now change the MCO image via a configmap - https://github.com/stolostron/multiclusterhub-operator#add-image-overrides-via-configmap Context https://redhat-internal.slack.com/archives/CUEMEHRA9/p1697051515351129

douglascamata commented 8 months ago

@coleenquadros ack. Will take a look at this when I have some time.