Add cmo config revert step to observability cleanup script

stolostron / deploy

Deploy Development Builds of Open Cluster Management (OCM) on RedHat Openshift Container Platform

Apache License 2.0

157 stars 152 forks source link

Add cmo config revert step to observability cleanup script #276

Closed philipgough closed 1 month ago

philipgough commented 1 month ago

Description of the change: This change allows a user to manually cleanup and revert the cluster monitoring configuration in in the openshift-monitoring namespace.

Typically the endpointmetrics operator initiates this step via a finalizer on the Observability Addon in the Hub. However if the Hub and Managed Cluster become incompatible for any reason, we may need some manual cleanup.

Depends on https://github.com/stolostron/multicluster-observability-operator/pull/1591

Motivation for the change:

https://issues.redhat.com/browse/ACM-13149

philipgough commented 1 month ago

@gurnben would you mind taking a look at this?

gurnben commented 1 month ago

/lgtm /approve

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gurnben, philipgough, saswatamcode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/stolostron/deploy/blob/master/OWNERS)~~ [gurnben] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment