Closed dhaiducek closed 2 years ago
/hold It looks good to me, holding in case you want Alex to double check it.
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication
The CI is passing now--this PR is ready for (re)review.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dhaiducek, gparvin
The full list of commands accepted by this bot can be found here.
The pull request process is described here
We use the latest Chrome version, so this should be CI validation that the new code is working since it failed for QE on v105
also:
┌────────────────────────────────────────────────────────────────────────────────────────────────┐
│ Cypress: 8.5.0 │
│ Browser: Chrome 105 (headless) │
/unhold
Addresses:
The culprit is a
compile
call by Handlebars in the wizard. One solution is to precompile the template but since it's a wizard we need the YAML to dynamically be recompiled, so updating the CSP does seem to be the solution.This PR matches a similar update in
console
:Other fields in the
console
PR match the defaults provided byhelmet
. (Seehelmet.contentSecurityPolicy(options)
at https://helmetjs.github.io/). The resulting CSP after the change:This also updates
caniuse-lite
, which is appearing in the logs and is a minor version update.