search

stolostron / multicloud-operators-foundation

Apache License 2.0
51 stars 35 forks source link

🐛 Stop adding managed cluster label for the namespace #781

Closed zhujian7 closed 1 month ago

zhujian7 commented 1 month ago

Stop adding managed cluster label for the namespace because import-controller already has the same logic

Fix https://issues.redhat.com/browse/ACM-14616

xuezhaojun commented 1 month ago

/test e2e

xuezhaojun commented 1 month ago

/test e2e

xuezhaojun commented 1 month ago

/test e2e

xuezhaojun commented 1 month ago

/test e2e

zhujian7 commented 1 month ago

/test e2e

zhujian7 commented 1 month ago

/retest

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

xuezhaojun commented 1 month ago

/test e2e

xuezhaojun commented 1 month ago

/test e2e

xuezhaojun commented 1 month ago

/test e2e

xuezhaojun commented 1 month ago

/test e2e

zhujian7 commented 1 month ago

/test e2e

zhujian7 commented 1 month ago

/assign @xuezhaojun @elgnay

xuezhaojun commented 1 month ago

/lgtm

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xuezhaojun, zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/stolostron/multicloud-operators-foundation/blob/main/OWNERS)~~ [zhujian7] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment