update k8s.io/client-go version in go.mod

stolostron / multicloud-operators-subscription-release

Managing helm release with operators for multicloud.

Apache License 2.0

5 stars 10 forks source link

update k8s.io/client-go version in go.mod #219

Closed ray-harris closed 2 years ago

ray-harris commented 2 years ago

Signed-off-by: Ray Harris raharris@redhat.com

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ray-harris To complete the pull request process, please assign rokej after the PR has been reviewed. You can assign the PR to them by writing /assign @rokej in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/stolostron/multicloud-operators-subscription-release/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

ray-harris commented 2 years ago

We're updating the dependencies for multiclusterhub-operator. In the subscription-release repo's go.mod, it requires k8s.io/client-go v12.0.0 which is an invalid version. This version is then changed to v0.21.3 in a replace statement.

Replace statements don't propagate up to modules that import them. So multiclusterhub-operator still sees the version as v12.0.0 and report an error when trying to update our go.mod.

This PR moves the correct version of v0.21.3 from a replace statement up to the require statement.