search

stolostron / multicluster-global-hub

the main repository for the multicluster global hub
Apache License 2.0
20 stars 29 forks source link

:sparkles: Add the cache filter with topic prefix #1043

Closed yanmxa closed 1 month ago

yanmxa commented 1 month ago

Summary

The previous cache key is based on the eventType. But if we support renaming the topic, we need the agent to send the event to the new topic again after the topic is changed. Otherwise, it might lose data when renaming the topics

Related issue(s)

Reference: https://github.com/stolostron/multicluster-global-hub/pull/1032

yanmxa commented 1 month ago

/retest

yanmxa commented 1 month ago

/retest

yanmxa commented 1 month ago

/test test-unit

yanmxa commented 1 month ago

/test test-unit

yanmxa commented 1 month ago

/retest

sonarcloud[bot] commented 1 month ago

Quality Gate Failed Quality Gate failed

Failed conditions
66.7% Coverage on New Code (required ≥ 70%)

See analysis details on SonarCloud

yanmxa commented 1 month ago

/override ci/prow/sonarcloud /override "SonarCloud Code Analysis"

openshift-ci[bot] commented 1 month ago

@yanmxa: Overrode contexts on behalf of yanmxa: SonarCloud Code Analysis, ci/prow/sonarcloud

In response to [this](https://github.com/stolostron/multicluster-global-hub/pull/1043#issuecomment-2270570524): >/override ci/prow/sonarcloud >/override "SonarCloud Code Analysis" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
yanmxa commented 1 month ago

/assign @clyang82 @ldpliu

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clyang82, yanmxa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[agent/OWNERS](https://github.com/stolostron/multicluster-global-hub/blob/main/agent/OWNERS)~~ [clyang82,yanmxa] - ~~[test/OWNERS](https://github.com/stolostron/multicluster-global-hub/blob/main/test/OWNERS)~~ [clyang82,yanmxa] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
clyang82 commented 1 month ago

/override "SonarCloud Code Analysis"