stolostron / multicluster-global-hub

the main repository for the multicluster global hub
Apache License 2.0
21 stars 32 forks source link

run e2e using default middleware and byo middleware #1078

Closed ldpliu closed 1 month ago

ldpliu commented 2 months ago

Summary

Related issue(s)

https://issues.redhat.com/browse/ACM-13318 Fixes #

ldpliu commented 2 months ago

/retest

ldpliu commented 2 months ago

/retest

ldpliu commented 2 months ago

/test test-e2e

ldpliu commented 2 months ago

/retest

ldpliu commented 1 month ago

/retest

ldpliu commented 1 month ago

/retest

ldpliu commented 1 month ago

/retest

ldpliu commented 1 month ago

/cc @clyang82 @yanmxa

yanmxa commented 1 month ago

Looks good to me. Leave it to @clyang82~

ldpliu commented 1 month ago

/retest

ldpliu commented 1 month ago

/retest

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

yanmxa commented 1 month ago

/lgtm

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clyang82, ldpliu, yanmxa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/stolostron/multicluster-global-hub/blob/main/OWNERS)~~ [clyang82,yanmxa] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment