search

stolostron / multicluster-global-hub

the main repository for the multicluster global hub
Apache License 2.0
21 stars 32 forks source link

:bug: Clean the transport connection #1160

Closed clyang82 closed 1 month ago

clyang82 commented 1 month ago

Summary

the manager is waiting for the transport connection. in the first time, the transport connection is empty. once the kafka is ready, the transport connection will be set as correct value. when reinstall, the transport connection keeps the previous value so that the manager and grafana will be deploy at the beginning.

Related issue(s)

Fixes # https://issues.redhat.com/browse/ACM-14761

Tests

yanmxa commented 1 month ago

/lgtm

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clyang82, yanmxa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/stolostron/multicluster-global-hub/blob/main/OWNERS)~~ [clyang82,yanmxa] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
clyang82 commented 1 month ago

/cherry-pick release-2.12

openshift-cherrypick-robot commented 1 month ago

@clyang82: once the present PR merges, I will cherry-pick it on top of release-2.12 in a new PR and assign it to you.

In response to [this](https://github.com/stolostron/multicluster-global-hub/pull/1160#issuecomment-2404512410): >/cherry-pick release-2.12 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

openshift-cherrypick-robot commented 1 month ago

@clyang82: new pull request created: #1161

In response to [this](https://github.com/stolostron/multicluster-global-hub/pull/1160#issuecomment-2404512410): >/cherry-pick release-2.12 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.