:bug: add update for the managedclusterinfo

stolostron / multicluster-global-hub

the main repository for the multicluster global hub

Apache License 2.0

21 stars 32 forks source link

:bug: add update for the managedclusterinfo #1170

Closed yanmxa closed 1 month ago

yanmxa commented 1 month ago

Summary

The agent needs to add a finalizer to the managedclusterinfo instances. so it can distinguish the updating and deleting events for the inventory API. Reference to https://github.com/stolostron/multicluster-global-hub/pull/1163

Related issue(s)

Fixes #

Tests

[ ] Unit/function tests have been added and incorporated into make unit-tests.
[ ] Integration tests have been added and incorporated into make integration-test.
[ ] E2E tests have been added and incorporated into make e2e-test-all.
[ ] List other manual tests you have done.

sonarcloud[bot] commented 1 month ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

clyang82 commented 1 month ago

/lgtm

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clyang82, yanmxa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/stolostron/multicluster-global-hub/blob/main/OWNERS)~~ [clyang82,yanmxa] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

clyang82 commented 2 weeks ago

/cherry-pick release-2.12

openshift-cherrypick-robot commented 2 weeks ago

@clyang82: new pull request created: #1218

In response to [this](https://github.com/stolostron/multicluster-global-hub/pull/1170#issuecomment-2470181382): >/cherry-pick release-2.12 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.