stolostron / multicluster-global-hub

the main repository for the multicluster global hub
Apache License 2.0
21 stars 32 forks source link

:bug: Fix update restart label #1191

Closed clyang82 closed 3 weeks ago

clyang82 commented 1 month ago

Summary

  1. restart the pod directly instead of add label if the certs are changed
  2. correct the cert name so that it can trigger the inventory api restarts
  3. should not use DeepDerivative for typed object due to https://github.com/kubernetes/apimachinery/issues/110. using unstructured.Unstructured

Related issue(s)

Fixes https://github.com/stolostron/multicluster-global-hub/issues/1125

Tests

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
75.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

yanmxa commented 3 weeks ago

/lgtm

openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clyang82, yanmxa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/stolostron/multicluster-global-hub/blob/main/OWNERS)~~ [clyang82,yanmxa] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment