search

stolostron / multicluster-global-hub

the main repository for the multicluster global hub
Apache License 2.0
21 stars 32 forks source link

:sparkles: Split add the webhook and backup controllers #1195

Closed yanmxa closed 2 weeks ago

yanmxa commented 3 weeks ago

Summary

encounter the error:

2024-11-05T01:57:11.661Z    ERROR   controller/controller.go:316    Reconciler error    {"controller": "strimzi_controller", "controllerGroup": "operator.open-cluster-management.io", "controllerKind": "MulticlusterGlobalHub", "MulticlusterGlobalHub": {"name":"test-mgh","namespace":"namespace-wh6g6w"}, "namespace": "namespace-wh6g6w", "name": "test-mgh", "reconcileID": "ea3dc69b-e288-478a-a392-3680d671dc58", "error": "failed to create/update kafka objects: podmonitors.monitoring.coreos.com \"amq-streams-cluster-operator-metrics\" already exists"}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).reconcileHandler
    /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.19.0/pkg/internal/controller/controller.go:316
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).processNextWorkItem
    /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.19.0/pkg/internal/controller/controller.go:263
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).Start.func2.2
    /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.19.0/pkg/internal/controller/controller.go:224
2024-11-05T01:57:11.670Z    ERROR   controller/controller.go:316    Reconciler error    {"controller": "transport", "controllerGroup": "operator.open-cluster-management.io", "controllerKind": "MulticlusterGlobalHub", "MulticlusterGlobalHub": {"name":"test-mgh","namespace":"namespace-v6x4z4"}, "namespace": "namespace-v6x4z4", "name": "test-mgh", "reconcileID": "69c68048-0597-498d-9270-baed638e8965", "error": "controller with name strimzi_controller already exists. Controller names must be unique to avoid multiple controllers reporting to the same metric"}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).reconcileHandler
    /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.19.0/pkg/internal/controller/controller.go:316
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).processNextWorkItem
    /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.19.0/pkg/internal/controller/controller.go:263
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).Start.func2.2
    /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.19.0/pkg/internal/controller/controller.go:224
2024-11-05T01:57:11.687Z    ERROR   controller/controller.go:316    Reconciler error    {"controller": "transport", "controllerGroup": "operator.open-cluster-management.io", "controllerKind": "MulticlusterGlobalHub", "MulticlusterGlobalHub": {"name":"test-mgh","namespace":"namespace-v6x4z4"}, "namespace": "namespace-v6x4z4", "name": "test-mgh", "reconcileID": "748b43e1-fc3b-4a38-b458-69041ab31064", "error": "controller with name strimzi_controller already exists. Controller names must be unique to avoid multiple controllers reporting to the same metric"}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).reconcileHandler
    /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.19.0/pkg/internal/controller/controller.go:316
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).processNextWorkItem
    /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.19.0/pkg/internal/controller/controller.go:263
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).Start.func2.2
    /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.19.0/pkg/internal/controller/controller.go:224

Fixed in this pr:https://github.com/stolostron/multicluster-global-hub/pull/1194

Related issue(s)

Fixes #

Tests

yanmxa commented 2 weeks ago

/retest

yanmxa commented 2 weeks ago

/test test-e2e /test test-integration

yanmxa commented 2 weeks ago

/cc @clyang82 @ldpliu

yanmxa commented 2 weeks ago

database connection error

/test test-e2e

sonarcloud[bot] commented 2 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
89.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

ldpliu commented 2 weeks ago

/lgtm

openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ldpliu, yanmxa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/stolostron/multicluster-global-hub/blob/main/OWNERS)~~ [yanmxa] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment