:sparkles: Migration enhancement

clyang82 commented 6 days ago

Summary

remove the backup secret since the -current-hub bookstrap secret can be added by default
retry for conflict error
wait for 10 seconds to ensure klusterletconfig is applied and then update hubAcceptClient to false to trigger the migration (TODO: there is condition indicates the klusterletconfig is applied)
remove the managed cluster when the cluster hubAcceptClient is false

Related issue(s)

Fixes # https://issues.redhat.com/browse/ACM-15220

Tests

[ ] Unit/function tests have been added and incorporated into make unit-tests.
[ ] Integration tests have been added and incorporated into make integration-test.
[ ] E2E tests have been added and incorporated into make e2e-test-all.
[x] List other manual tests you have done.
verified in local environment

yanmxa commented 2 days ago

/lgtm

openshift-ci[bot] commented 2 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clyang82, yanmxa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/stolostron/multicluster-global-hub/blob/main/OWNERS)~~ [clyang82,yanmxa] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

sonarcloud[bot] commented 2 days ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
86.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

stolostron / multicluster-global-hub