Closed yanmxa closed 1 week ago
Failed conditions
43.1% Coverage on New Code (required β₯ 70%)
/override ci/prow/sonarcloud
@yanmxa: Overrode contexts on behalf of yanmxa: ci/prow/sonarcloud
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: clyang82, yanmxa
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Could we set the log level using annotation in mgh?
@ldpliu No, The log level is adjusted by the config map: https://github.com/stolostron/multicluster-global-hub/blob/main/doc/troubleshooting.md#change-the-mutlicluster-global-hub-log-level-at-runtime
The reason why we don't use the annotation for the CR is the operator log level can't be modified by it
/test images
Summary
The log data
Related issue(s)
Fixes # https://issues.redhat.com/browse/ACM-13421
Reference: https://github.com/stolostron/multicluster-global-hub/issues/1178
Tests
make unit-tests
.make integration-test
.make e2e-test-all
.