:bug: Inactive the managed hub by addon

stolostron / multicluster-global-hub

the main repository for the multicluster global hub

Apache License 2.0

21 stars 32 forks source link

:bug: Inactive the managed hub by addon #1244

Closed yanmxa closed 3 days ago

yanmxa commented 5 days ago

Summary

Related issue(s)

Fixes # https://issues.redhat.com/browse/ACM-14959

Tests

[x] Unit/function tests have been added and incorporated into make unit-tests.
[ ] Integration tests have been added and incorporated into make integration-test.
[ ] E2E tests have been added and incorporated into make e2e-test-all.
[ ] List other manual tests you have done.

yanmxa commented 3 days ago

/test sonarcloud

yanmxa commented 3 days ago

/test sonarcloud

yanmxa commented 3 days ago

/override ci/prow/sonarcloud

openshift-ci[bot] commented 3 days ago

@yanmxa: Overrode contexts on behalf of yanmxa: ci/prow/sonarcloud

In response to [this](https://github.com/stolostron/multicluster-global-hub/pull/1244#issuecomment-2496484567): >/override ci/prow/sonarcloud Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

yanmxa commented 3 days ago

/override ci/prow/sonarcloud

openshift-ci[bot] commented 3 days ago

@yanmxa: Overrode contexts on behalf of yanmxa: ci/prow/sonarcloud

In response to [this](https://github.com/stolostron/multicluster-global-hub/pull/1244#issuecomment-2496492295): >/override ci/prow/sonarcloud Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

clyang82 commented 3 days ago

/lgtm

openshift-ci[bot] commented 3 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clyang82, yanmxa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/stolostron/multicluster-global-hub/blob/main/OWNERS)~~ [clyang82,yanmxa] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

sonarcloud[bot] commented 3 days ago

Quality Gate failed

Failed conditions
46.8% Coverage on New Code (required ≥ 70%)

See analysis details on SonarQube Cloud

yanmxa commented 3 days ago

/override ci/prow/sonarcloud

openshift-ci[bot] commented 3 days ago

@yanmxa: Overrode contexts on behalf of yanmxa: ci/prow/sonarcloud

In response to [this](https://github.com/stolostron/multicluster-global-hub/pull/1244#issuecomment-2496601433): >/override ci/prow/sonarcloud Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

openshift-ci[bot] commented 3 days ago

@yanmxa: Overrode contexts on behalf of yanmxa: ci/prow/sonarcloud

In response to [this](https://github.com/stolostron/multicluster-global-hub/pull/1244#issuecomment-2496602104): >/override ci/prow/sonarcloud Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.